Put the current mode of the plane into a string #50
Conversation
| @@ -24,6 +24,7 @@ message Overview { | |||
| Velocity vel = 5; | |||
| Speed speed = 6; | |||
| Battery battery = 7; | |||
| string mode = 8; | |||
There was a problem hiding this comment.
Hmm, I wonder if we should enumerate the mode. This works for now though, and enumerating has complications because the custom mode differs based on the firmware.
There was a problem hiding this comment.
Can add an endpoint for returning the available modes for the autopilot in strings for the future?
There was a problem hiding this comment.
Also the file mode on this file changed in the commit
There was a problem hiding this comment.
You need to verify that the autopilot is not PX4 and that the mav_type is coming from a fixed wing plane before doing mode conversions. Need to add a test checking that the mode has been classified. I'd also break the logic out for classifying the mode into a separate mode.js file and keep in mind variable naming conventions on declaring the mode mapping constant.
|
Closing in favor of just including the functionality done here in #53. |
|
Wait what? |
|
It was true, |
Added the mode of the plane as a string to the overview telemetry protobuf message.