PHP 8.2 Migration Prep: add dyn properties #2040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 8.2 dynamically creating properties has been deprecated ( https://php.watch/versions/8.2/dynamic-properties-deprecated ). As the changes to support this are compatible with PHP 7.4 this PR can be merged prior to the main 7.4 -> 8.2 upgrade.
ryanrath
added
autodoc:ignore
ryanrath
requested review from
aaronweeden,
aestoltm,
connersaeli,
eiffel777,
jpwhite4 and
rvtovar
Contributor
|
I'll approve this but I would really like appropriate comments added for each of the properties. I know that's a bit of a pain but I think it will be helpful. |
eiffel777
previously approved these changes
Sep 22, 2025
Contributor
Author
|
@eiffel777 I mean, I can give go through and try and do basics like, add expected types and what it looks like the properties purpose is, but doing a 100% deep dive into each property and it's purpose is outside the scope of this particular PR. |
Contributor
Yeah, having at least the type would be helpful. I'm fine with that. |
eiffel777
previously approved these changes
Sep 23, 2025
eiffel777
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes were derived from the composer library
rector/rectorwhich helps identify php code that matches specific rules / sets of rules. In this case the rule used was the "Complete Dynamic Properties" https://getrector.com/rule-detail/complete-dynamic-properties-rector .NOTE: If you dry-run that rule on a freshly checked out XDMoD repo it will include some white space modifications. I have not included those changes in this PR
Motivation and Context
As of PHP 8.2 dynamically creating properties for an object has been deprecated ( https://php.watch/versions/8.2/dynamic-properties-deprecated ). As the changes to support this are compatible with PHP 7.4 this PR can be merged prior to the main 7.4 -> 8.2 upgrade.
Tests performed
All automated tests have been run locally.
Checklist: