This repository was archived by the owner on Sep 25, 2020. It is now read-only.
introduce max_req_timeout_count #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not healthy. If the endpoint is still ligit, pinger will bring it back, otherwise say the endpoint is totally down, the endpoint will stay as not healthy. This helps us find dead endpoints that the server box is totally down.
Author
Author
|
@zhijinli this is the diff to handle the dead host issue. |
Collaborator
|
@BinChang please take a look at https://github.com/uber/tchannel-node/blob/469bd9a4e2e6db72864ad6db25c57ed040ae695f/operations.js#L203-L220 for inspiration :) |
Author
|
@Raynos That's the same idea, tChannel manages tcp socket errors directly, but lb_pool runs request through http. |
| PoolEndpoint.prototype.request_succeeded = function (request, response, body) { | ||
| this.successes++; | ||
| this.complete(null, request, response, body); | ||
| this.reset_req_timeout_count(); |
Collaborator
There was a problem hiding this comment.
Also reset() in the else case in request_failed ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count # of consecutive req_timeout, and if it is too high, mark it as not healthy. If the endpoint is still legit, pinger will bring it back, otherwise if the endpoint is totally down, the endpoint will stay as unhealthy.
This helps us find dead endpoints whose server box is totally down.