This repository was archived by the owner on Sep 25, 2020. It is now read-only.
Support rolling restart in tick-cluster #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanodnl
reviewed
Jan 27, 2017
|
|
||
| function restartProc(batchSize) { | ||
| if (batchSize === 0) { | ||
| return; |
There was a problem hiding this comment.
maybe add output to indicate it is backing out because of invalid input
There was a problem hiding this comment.
At all other places, tick-cluster silently ignores incorrect input
tools/tick-cluster.js
Outdated
| logFn('\tK\t\tRevive suspended or killed processes'); | ||
| logFn('\tl <count>\tSuspend processes'); | ||
| logFn('\tm <count>\tTerminate processes'); | ||
| logFn('\tr <batch size>\tRestart processes'); |
There was a problem hiding this comment.
I think the list is in alphabetic order, except for this line. Lets move it down a bit.
There was a problem hiding this comment.
Yeah, you're right; I put it in logical order but the rest if alphabetic. I'll reorder.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.