-
Notifications
You must be signed in to change notification settings - Fork 146
Conversation
LGTM |
The change to the readme looks good and can be merged, but shall we also specify the version in the |
LGTM but let's add the |
I'm not completely sure if
All seem to have troubles with our package json dependencies section where the
Even though the problem is not with |
Ah thanks @thanodnl for looking into this. Should we specify Maybe I should do a sanity check of versions above 0.10.32. |
Travis tests run on v0.10.45 successfully so I'm just gonna merge this. |
LGTM! |
dff7ce8
to
87a63a4
Compare
87a63a4
to
eeca7d3
Compare
Merged in commit ee72383. |
Add a section to the README documenting the requirements for ringpop-node.
This should help people run into trouble when trying to
npm install
on a newer version of node1.