[Custom Build Steps] Fixes to get custom build steps working. #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed the custom build steps project isn't being built and tested. I was going to add it but it contains bff files which then have local state (i.e. would reference my community edition of visual studio). But I did generate and test it locally and it works fine. |
kudaba
force-pushed
the
pr/custom_build_step_fix
branch
from
72046c0 to
e61de6b
Compare
* Add quotes to executable if it's a single line string that doesn't already have quotes. * Standardize the path when looking up the build step since it may be lower cased.
kudaba
force-pushed
the
pr/custom_build_step_fix
branch
from
e61de6b to
5e7ae00
Compare
|
what case is this fixing exactly? Could you give us an example of a real world case. We don't really understand what this is fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrecting #101 that got deleted when I renamed some branches.