Skip to content

Fix crash when using AdditionalManifestFiles on 32-bit Windows targets #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix crash when using AdditionalManifestFiles on 32-bit Windows targets #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Sharpmake.Platforms/Sharpmake.CommonPlatforms/Windows/BaseWindowsPlatform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ public static partial class Windows
{
public abstract class BaseWindowsPlatform : BaseMicrosoftPlatform, IWindowsFastBuildCompilerSettings
{
#region IPlatformDescriptor implementation
public override EnvironmentVariableResolver GetPlatformEnvironmentResolver(params VariableAssignment[] assignments)
{
return new Win64EnvironmentVariableResolver(assignments);
}
#endregion

#region IWindowsFastBuildCompilerSettings implementation
public override bool IsPcPlatform => true;
public IDictionary<DevEnv, string> BinPath { get; set; } = new Dictionary<DevEnv, string>();
Expand Down
5 changes: 0 additions & 5 deletions Sharpmake.Platforms/Sharpmake.CommonPlatforms/Windows/Win64Platform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ public sealed class Win64Platform : BaseWindowsPlatform
#region IPlatformDescriptor implementation
public override string SimplePlatformString => "Win64";
public override string GetToolchainPlatformString(ITarget target) => "x64";

public override EnvironmentVariableResolver GetPlatformEnvironmentResolver(params VariableAssignment[] assignments)
{
return new Win64EnvironmentVariableResolver(assignments);
}
#endregion

#region IMicrosoftPlatformBff implementation
Expand Down
Loading