Minor custom build step resolving improvement/fix #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tom build step. In all cases sharpmake uses 'conf' as resolve parameter name when resolving sharpmake strings, all but in the case of custom build steps where 'config' is used instead. This seems like a simple oversight, so this change also adds 'conf' for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also supply 'conf' for the current configuration when resolving a custom build step.
In all cases Sharpmake uses 'conf' as resolve parameter name when resolving Sharpmake strings. But in the case of custom build steps 'config' is used instead and 'conf' isn't specified. This seems like a simple oversight, so this change also adds 'conf' for consistency.