Skip to content

Extend FASTBuild bff generator to support CustomFileBuildStep.AdditionalInputs #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinecker-ATVI wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extend FASTBuild bff generator to support CustomFileBuildStep.AdditionalInputs #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Sharpmake.Generators/FastBuild/Bff.Util.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,9 +859,16 @@ internal static void WriteCustomBuildStepAsGenericExecutable(string projectRoot,
return relativePath;
});

Strings inputFiles = new();
inputFiles.Add(relativeBuildStep.KeyInput);
foreach (string inputFile in relativeBuildStep.AdditionalInputs)
{
inputFiles.Add(inputFile);
}

using (bffGenerator.Declare("fastBuildPreBuildName", relativeBuildStep.Description))
using (bffGenerator.Declare("fastBuildPrebuildExeFile", relativeBuildStep.Executable))
using (bffGenerator.Declare("fastBuildPreBuildInputFiles", FBuildFormatSingleListItem(relativeBuildStep.KeyInput)))
using (bffGenerator.Declare("fastBuildPreBuildInputFiles", FBuildFormatList(inputFiles.ToList(), 26)))
using (bffGenerator.Declare("fastBuildPreBuildOutputFile", relativeBuildStep.Output))
using (bffGenerator.Declare("fastBuildPreBuildArguments", string.IsNullOrWhiteSpace(relativeBuildStep.ExecutableArguments) ? FileGeneratorUtilities.RemoveLineTag : relativeBuildStep.ExecutableArguments))
// This is normally the project directory.
Expand Down
1 change: 0 additions & 1 deletion Sharpmake/Project.Configuration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2360,7 +2360,6 @@ public enum ProjectFilter
public string OutputItemType = "";

/// <summary>
/// Not supported by FASTBuild.
/// Additional files that will cause a re-run of this custom build step can be be specified here.
/// </summary>
public Strings AdditionalInputs = new Strings();
Expand Down