Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

Add golden test #320

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add golden test #320

wants to merge 1 commit into from

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Mar 14, 2023

@jpnurmi

This comment was marked as outdated.

@jpnurmi jpnurmi force-pushed the screenshots branch 13 times, most recently from b845efc to b92e2ab Compare May 18, 2023 20:31
@jpnurmi jpnurmi changed the title Add integration test for taking screenshots of the example Add golden test May 18, 2023
Ref: #315
@Feichtmeier
Copy link
Member

@d-loose @robert-ancell we really need this PR to become better with detecting visual regressions
Could you help with finishing this?

@d-loose
Copy link
Member

d-loose commented Nov 20, 2023

I'm definitely in favor of adding those tests - I don't know how much work is left to be done and when/if I have time to focus on that, though.

Copy link
Contributor

No release type found in pull request title "Add golden test". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants