Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

chore: release v1.0.0 #379

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 8, 2023

🤖 I have created a release beep boop

1.0.0 (2023-08-15)

What's Changed

Full Changelog: ubuntu/yaru.dart@v0.10.0...v1.0.0


This PR was generated with Release Please. See documentation.

Closes #377

@github-actions github-actions bot force-pushed the release-please--branches--main--components--yaru branch from 0670986 to db3b339 Compare August 9, 2023 17:53
@github-actions github-actions bot changed the title chore: release v0.10.1 chore: release v1.0.0 Aug 15, 2023
@github-actions github-actions bot force-pushed the release-please--branches--main--components--yaru branch 5 times, most recently from 23e08ec to 15929b8 Compare August 15, 2023 13:05
@Feichtmeier
Copy link
Member

@Jupi007 anything else for 1.0.0 ?

@Jupi007
Copy link
Member

Jupi007 commented Aug 15, 2023

What do you think of set SnackBarThemeData.showCloseIcon to true?

image

It is a material icon, but I think that it is very confusing to close the snackbar with a click-drag.

Also, maybe fix the IconButton.filled icon color:

image

@Feichtmeier
Copy link
Member

I played with the close button but to change it we would need to change actionicontheme with our own icon theme but we don't want to make yaru icons a dep of yaru, do we?
also the padding is somehow hardcoded :S so I would prefer to not enable it by default

I try to change the filled icon button but I think it is currently not possible

I try to fix the secondary color issue

@Jupi007
Copy link
Member

Jupi007 commented Aug 15, 2023

I played with the close button but to change it we would need to change actionicontheme with our own icon theme but we don't want to make yaru icons a dep of yaru, do we?
also the padding is somehow hardcoded :S so I would prefer to not enable it by default

Okay 👍
That we can do later is create our own snackbar in yaru widgets, with our own design and icon.

@github-actions github-actions bot force-pushed the release-please--branches--main--components--yaru branch from 15929b8 to 80558a7 Compare August 15, 2023 16:58
@Feichtmeier Feichtmeier merged commit 496d4ee into main Aug 15, 2023
1 check passed
@Feichtmeier Feichtmeier deleted the release-please--branches--main--components--yaru branch August 15, 2023 17:04
@github-actions
Copy link
Contributor Author

🤖 Release is at https://github.com/ubuntu/yaru.dart/releases/tag/v1.0.0 🌻

@Feichtmeier
Copy link
Member

Finally yaru 1.0 😄

@jpnurmi may be proud of us 💙

Bildschirmaufzeichnung.vom.2023-08-15.19-05-32.webm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.0?
2 participants