You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description
This pull request addresses code organization concerns by relocating the methods of YaruVariant within the enum itself. This refactor takes advantage of the enhanced enums introduced in Dart 2.17. The primary goal is to centralize YaruVariant related code inside the enum itself.
This was one of the edit proposed in this pull request (#398), which i closed and splitted in more pull request as requested
@Feichtmeier here is one of the two pull request 😃
If you need a test with a GNOME Linux OS and an application I will provide soon as possible
Thanks for the pr
Yes we need to check if it works from gnome control center because this is what the YaruTheme is for
Ok, I have atm my M1 Macbook, when i go back home i will test with my Pc with Pop OS, okay?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses code organization concerns by relocating the methods of
YaruVariantwithin the enum itself. This refactor takes advantage of the enhanced enums introduced in Dart 2.17. The primary goal is to centralizeYaruVariantrelated code inside the enum itself.This was one of the edit proposed in this pull request (#398), which i closed and splitted in more pull request as requested
Here is a brief video to show that the variant switch correctly
https://github.com/ubuntu/yaru.dart/assets/62995808/ee095f7d-10f7-4414-9396-1c907b676d00