Add tests for EntraID's specific GetUserInfo #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisonbarbosa
force-pushed
the
entraid-grps-tests
branch
3 times, most recently
from
1337b92 to
db784e2
Compare
3v1n0
reviewed
Feb 28, 2025
adombeck
reviewed
Mar 14, 2025
adombeck
reviewed
Mar 14, 2025
adombeck
reviewed
Mar 14, 2025
adombeck
reviewed
Mar 14, 2025
adombeck
reviewed
Mar 14, 2025
adombeck
reviewed
Mar 14, 2025
denisonbarbosa
force-pushed
the
entraid-grps-tests
branch
from
54575d8 to
d01cf2d
Compare
Since we only care about the .Claims() method in the ID Token, we can switch to using a interface in the providers definitions so we can mock an ID token in the tests.
We used to parse it only when needed, but that created some issues when testing it, since the https protocol could not be overriden and we don´t want to install certificates when running tests.
This would panic if the group did not have a displayName. It's unlikely to happen often (if it happens at all), but we should cover this possibility nonetheless.
denisonbarbosa
force-pushed
the
entraid-grps-tests
branch
from
d01cf2d to
541ac48
Compare
adombeck
approved these changes
Mar 17, 2025
This is mainly focused on mocking the groups endpoint, but we could extend it later if necessary.
denisonbarbosa
force-pushed
the
entraid-grps-tests
branch
from
541ac48 to
41bc23b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were lacking tests for the MSEntraID's GetUserInfo function. Now we properly test the groups parsing and filtering.
UDENG-6033