Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining incorrect uses of the term "challenge" #836

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adombeck
Copy link
Contributor

Follow-up of UDENG-5180, where we couldn't fix the uses of "challenge" in our API with the broker without breaking the API. Now 98% of brokers have been updated to version 0.2.0 which supports using "secret" instead of "challenge" in the API, so we now rename it on the authd side.

Follow-up of UDENG-5180, where we couldn't fix the uses of "challenge"
in our API with the broker without breaking the API. Now 98% of brokers
have been updated to version 0.2.0 which supports using "secret" instead
of "challenge" in the API, so we now rename it on the authd side.
@adombeck adombeck marked this pull request as ready for review March 14, 2025 15:30
@adombeck adombeck requested a review from a team as a code owner March 14, 2025 15:30
@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 14, 2025

I guess that this, unless we don't have a clone type that uses the old naming, would break gdm. I'm fine with changing the API, but we should then coordinate for the uploads, so that we can probably merge this together with #827 (that already has a Breaks on older shells).

Probably not a big deal for now, but note that this would break the version of gnome-shell that is in distro (and that already supports authd). Since initially the idea was to not have to maintain too much the shell in the PPA but rely on the one in the archive (that has a safer and more defined update path).

@adombeck
Copy link
Contributor Author

I forgot that the AuthenticationData message is also used in the gdm service. We could avoid breakage by adding a new field Secret and mark the old Challenge field as deprecated. WDYT?

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 17, 2025

I forgot that the AuthenticationData message is also used in the gdm service. We could avoid breakage by adding a new field Secret and mark the old Challenge field as deprecated. WDYT?

That's an option, but given we'd break gdm all the way with the other MR it's probably better to just do it all in, so that we don't have to do re-iterations and handle breaks in future anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants