Remove database on schema creation failure #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
reviewed
Mar 14, 2025
|
I added a test |
|
Did you push it? 🤔 |
I noticed that if the schema creation fails (e.g. because the schema is invalid), the database file is still created and authd uses it the next time it's started. That results in authd starting up successfully but in failure of each request which uses the broken database. Let's avoid that by ensuring that the database file is removed when the schema creation fails.
adombeck
force-pushed
the
remove-db-on-schema-creation-failure
branch
from
5107002 to
ccfeb52
Compare
3v1n0
reviewed
Mar 19, 2025
The pre-push hook failed :/ I pushed it with ccfeb52 |
3v1n0
approved these changes
Mar 19, 2025
adombeck
force-pushed
the
remove-db-on-schema-creation-failure
branch
from
ccfeb52 to
7f8f24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if the schema creation fails (e.g. because the schema is invalid), the database file is still created and authd uses it the next time it's started. That results in authd starting up successfully but in failure of each request which uses the broken database.
Let's avoid that by ensuring that the database file is removed when the schema creation fails.
UDENG-6482