Update libmozjs to 115 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GJS is built with libmozjs-115-dev, but in the dependencies for the SDK itself the old limbozjs-102-dev is used. This PR fixes this.
|
Should we keep both versions? (102 and 115) Or it should be enough with the latest one? |
|
Si el target es 2404 creo que sea mejor dejar solo la 115. 102 era solo para 22.04. |
|
Ops, sorry... I saw Sergio and I went Spanish 😂. Anyways, I think 115 is well enough for apps targetting 24.04. :) |
|
I'm fully de acuerdo :-D |
|
Oh, the only thing... On the non-sdk snap we should likely keep the old version, as the apps compiled with the old version of SDK won't work otherwise. |
|
Mmm... but the non-sdk snap is built from the sdk one, so then we must include it here... |
|
I'll prepare a new PR. |
|
I think we should remove 102, we didn't really migrate anything to gnome46 yet since we hit snapd issues trying to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GJS is built with libmozjs-115-dev, but in the dependencies for the SDK itself the old limbozjs-102-dev is used. This PR fixes this.