Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all parts to the last stable version #250

Merged

Conversation

sergio-costas
Copy link
Contributor

No description provided.

@sergio-costas
Copy link
Contributor Author

Should gnome-desktop be updated to 46.X version?

@jssotomdz
Copy link
Contributor

Should gnome-desktop be updated to 46.X version?

I'd say yes, is it not being picked up by the automation because of the same-major parameter?

@soumyaDghosh
Copy link
Contributor

soumyaDghosh commented Oct 14, 2024

@sergio-costas @jssotomdz Can't libadwaita be updated to 1.6? It's in stable now. Also the patches for libadwaita needs to be updated.

@sergio-costas
Copy link
Contributor Author

@soumyaDghosh The problem with libadwaita is that it requires some patches, and for version 1.6 they require some extra work. For 1.5.5, instead, just with some little adjustments they work. So, for the moment, I will just update to 1.5.5.

@soumyaDghosh
Copy link
Contributor

@soumyaDghosh The problem with libadwaita is that it requires some patches, and for version 1.6 they require some extra work. For 1.5.5, instead, just with some little adjustments they work. So, for the moment, I will just update to 1.5.5.

I believe the patches can be taken from here

https://salsa.debian.org/gnome-team/libadwaita/-/tree/ubuntu/1.6.0-1ubuntu2/debian/patches/ubuntu?ref_type=tags

These were patched by @3v1n0

@sergio-costas sergio-costas marked this pull request as draft October 14, 2024 18:11
@seb128
Copy link
Contributor

seb128 commented Oct 15, 2024

The commits are a bit confusing, could you rebase/squash as appropriate?

@sergio-costas sergio-costas force-pushed the update-to-last-version branch 2 times, most recently from 98ca370 to f6c2ea5 Compare October 15, 2024 13:38
@sergio-costas
Copy link
Contributor Author

@seb128 Done.

But it still has to be decided whether gnome-desktop should be updated to version 46, or kept in version 44. Also, maybe you prefer to not update librsvg, since it requires a rust version bigger than the currently available as .debs. Finally, what should we do with libadwaita? Update it to 1.6.x, or keep it in 1.5.x?

Didn't update gobject-introspection to 1.82.0 because it breaks
libportal introspection.

Also didn't update neither libadwaita to 1.6.1 nor gnome-desktop
46 because I think that we should discuss it before.
@seb128
Copy link
Contributor

seb128 commented Oct 15, 2024

I would update gnome-desktop and libadwaita unless there is a reason to not do so?

@sergio-costas
Copy link
Contributor Author

Funny... there's no gnome-desktop 46, it's still at 44.1. So we can forget that.

@sergio-costas sergio-costas marked this pull request as ready for review October 16, 2024 10:45
@sergio-costas
Copy link
Contributor Author

Updated everything, and tested the generated "gnome-46-2404" with evince and epiphany (in the later, went to Youtube and played a video). Everything seems to work fine.

Copy link
Member

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Unrelated to your change I noticed the gtk4 part does have -Dbuild-tests=false twice, we should clean that up but not a blocker for merging this.

@kenvandine kenvandine merged commit 6190750 into ubuntu:gnome-46-2404-sdk Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants