-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated all parts to the last stable version #250
Updated all parts to the last stable version #250
Conversation
Should gnome-desktop be updated to 46.X version? |
I'd say yes, is it not being picked up by the automation because of the same-major parameter? |
@sergio-costas @jssotomdz Can't libadwaita be updated to |
@soumyaDghosh The problem with libadwaita is that it requires some patches, and for version 1.6 they require some extra work. For 1.5.5, instead, just with some little adjustments they work. So, for the moment, I will just update to 1.5.5. |
I believe the patches can be taken from here These were patched by @3v1n0 |
The commits are a bit confusing, could you rebase/squash as appropriate? |
98ca370
to
f6c2ea5
Compare
@seb128 Done. But it still has to be decided whether gnome-desktop should be updated to version 46, or kept in version 44. Also, maybe you prefer to not update librsvg, since it requires a rust version bigger than the currently available as .debs. Finally, what should we do with libadwaita? Update it to 1.6.x, or keep it in 1.5.x? |
Didn't update gobject-introspection to 1.82.0 because it breaks libportal introspection. Also didn't update neither libadwaita to 1.6.1 nor gnome-desktop 46 because I think that we should discuss it before.
f6c2ea5
to
cf0fd5a
Compare
I would update gnome-desktop and libadwaita unless there is a reason to not do so? |
Funny... there's no gnome-desktop 46, it's still at 44.1. So we can forget that. |
Updated everything, and tested the generated "gnome-46-2404" with evince and epiphany (in the later, went to Youtube and played a video). Everything seems to work fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Unrelated to your change I noticed the gtk4 part does have -Dbuild-tests=false twice, we should clean that up but not a blocker for merging this.
No description provided.