-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --update option #693
Merged
Merged
add --update option #693
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9d78926
add --update option
NicolasKeita b412e55
Merge branch 'ubuntu:master' into master
NicolasKeita e7b3d36
remove duplicate code in each frameworks about '-update'
NicolasKeita 3b77df8
Refactor: Explicitly set updateability for certain frameworks
NicolasKeita ee53ec8
Add placeholder for tests about --update
NicolasKeita File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,6 +79,18 @@ def post_install(self): | |
add_env_to_user(self.name, {"PATH": {"value": os.path.join(self.install_path, "bin")}}) | ||
UI.delayed_display(DisplayMessage(self.RELOGIN_REQUIRE_MSG.format(self.name))) | ||
|
||
def parse_latest_version_from_package_url(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are fine, since they add what is specific to a package, although they could simply return the regex string, and let a method in baseinstaller deal with evaluating the regex |
||
return (re.search(r'/(\d+\.\d+\.\d+)', self.package_url).group(1) | ||
if self.package_url else 'Missing information') | ||
|
||
@staticmethod | ||
def get_current_user_version(install_path): | ||
try: | ||
with open(os.path.join(install_path, 'version'), 'r') as file: | ||
return file.readline().strip() if file else 'Missing information' | ||
except FileNotFoundError: | ||
return 'Missing information' | ||
|
||
|
||
class FlutterLang(umake.frameworks.baseinstaller.BaseInstaller): | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially you can remove these empty methods, and add them to baseinstaller/init
so the single frameworks only override this if they can