Skip to content

Move FireChip target-specific CI from FireSim to Chipyard #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Aug 22, 2024

Now that FireSim is isolated from Chipyard (all target specific bridges, harnesses, etc live in Chipyard), it makes sense to also move the FireSim CI here as well.

This PR does the following:

  • Moves FireSim target-specific CI here. This includes (1) running FireSim metasimulations on default designs always (2) running FireSim's bitstream builds (runnable by adding ci:local-fpga-buildbitstream-deploy) (3) running FireSim's FPGA simulation of Linux boot on default designs (runnable by adding ci:fpga-deploy). Default designs means single/multi-core Rocket and single-core LargeBOOM.
    • It's up to a Chipyard dev to make a PR building/testing bitstreams adhoc
  • Removes need for code doing FireSim-as-top
  • Updates the documentation to point to the new flow.
  • Adds a helper typecheck script

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez force-pushed the isolate-chipyard-from-firesim branch from 64aa893 to a800cd0 Compare August 27, 2024 00:00
abejgonzalez added a commit that referenced this pull request Aug 27, 2024
Update local bitstream(s) for PR #2014 (`isolate-chipyard-from-firesim`)
@abejgonzalez abejgonzalez force-pushed the isolate-chipyard-from-firesim branch from c86530b to 002b3ac Compare August 27, 2024 04:54
@abejgonzalez abejgonzalez force-pushed the isolate-chipyard-from-firesim branch from d82ca9d to d7a03bb Compare August 27, 2024 08:24
@abejgonzalez abejgonzalez requested a review from jerryz123 August 27, 2024 16:16
@abejgonzalez abejgonzalez force-pushed the isolate-chipyard-from-firesim branch from c89ea3f to 33db4ed Compare August 27, 2024 23:01
@abejgonzalez abejgonzalez force-pushed the isolate-chipyard-from-firesim branch from 33db4ed to 513391d Compare August 28, 2024 04:37
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the files that were copied from firesim are fine.

@abejgonzalez abejgonzalez merged commit eae7f6f into main Aug 28, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants