Skip to content

Quick fix: Scans check for $_ENV['VERSION_NUMBER'] #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 9, 2025

Conversation

mbusch3
Copy link

@mbusch3 mbusch3 commented Jun 18, 2025

When a scan is run, it now saves the current version number of the code as versionNumber in the report "data" object. Whenever a new "sync" scan is run (when the app loads), it reads the last report's data and checks for the versionNumber and if it doesn't exist or is different from the current version, then instead of a targeted "only check updated content" scan, it does a full course rescan. This will help remove errors that are no longer applicable and make sure that the most up-to-date changes are consistently reflected.

Note: Once you apply this fix, it should do a full rescan the first time, since the existing report data doesn't have a versionNumber attribute. But you'll need to change the VERSION_NUMBER variable in your .env file to catch the difference after that.

@dmols dmols self-requested a review July 7, 2025 13:31
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to test the VERSION_NUMBER change but I have a few notes about the other updates!

  • I wonder if it'd get a little confusing for the user to see the checkmark on save changes before the issue is already fixed?
    Screenshot 2025-07-07 at 9 26 06 AM

  • It seems we're missing a rule in the en.json for this particular case, which is repeated a lot for files.
    Screenshot 2025-07-07 at 9 25 34 AM

  • Lastly, I noticed we're getting this issue with 'Headers Should Show Page Structure'.
    Screenshot 2025-07-07 at 9 25 19 AM

  • This is an issue in new-main-page-UX currently, but I'm not sure if we found a fix for it. Essentially, when you hit 'save' it'll turn to this, since it can't find the content anymore.

Overall though, I really do like the UI changes, this feels a lot neater!

@mbusch3
Copy link
Author

mbusch3 commented Jul 8, 2025

Today's two commits add "recommendations" to the local scanner settings, and also removes any "PASS"ed tests from the results if the users have turned them on (I imagine that we could turn that into an ENV setting sometime).

Most of the xpath logic was still in the code (services\Html.js), but it just had to be re-linked up to the handleIssueSave function. Should be pretty easy to see if it's working. :)

@dmols dmols self-requested a review July 9, 2025 15:40
@dmols dmols self-assigned this Jul 9, 2025
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as expected! Still pending to check the $_ENV['VERSION_NUMBER'] change thoroughly, but that can happen after this upcoming deploy. The app works as intended.

@dmols dmols merged commit 31cdb1b into ucfopen:new-main-page-UX Jul 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants