-
Notifications
You must be signed in to change notification settings - Fork 75
Quick fix: Scans check for $_ENV['VERSION_NUMBER'] #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…summaries for issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't been able to test the VERSION_NUMBER
change but I have a few notes about the other updates!
-
I wonder if it'd get a little confusing for the user to see the checkmark on save changes before the issue is already fixed?
-
It seems we're missing a rule in the
en.json
for this particular case, which is repeated a lot for files.
-
Lastly, I noticed we're getting this issue with 'Headers Should Show Page Structure'.
-
This is an issue in
new-main-page-UX
currently, but I'm not sure if we found a fix for it. Essentially, when you hit 'save' it'll turn to this, since it can't find the content anymore.
Overall though, I really do like the UI changes, this feels a lot neater!
Today's two commits add "recommendations" to the local scanner settings, and also removes any "PASS"ed tests from the results if the users have turned them on (I imagine that we could turn that into an ENV setting sometime). Most of the xpath logic was still in the code ( |
…rms. Needed to pass down some data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes work as expected! Still pending to check the $_ENV['VERSION_NUMBER']
change thoroughly, but that can happen after this upcoming deploy. The app works as intended.
When a scan is run, it now saves the current version number of the code as
versionNumber
in the report "data" object. Whenever a new "sync" scan is run (when the app loads), it reads the last report's data and checks for theversionNumber
and if it doesn't exist or is different from the current version, then instead of a targeted "only check updated content" scan, it does a full course rescan. This will help remove errors that are no longer applicable and make sure that the most up-to-date changes are consistently reflected.Note: Once you apply this fix, it should do a full rescan the first time, since the existing report data doesn't have a
versionNumber
attribute. But you'll need to change theVERSION_NUMBER
variable in your.env
file to catch the difference after that.