-
Notifications
You must be signed in to change notification settings - Fork 74
Rotate keys functionality and removing hardcoded encryption key #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…esting since my udoit is messed up still
dmols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this branch on my end and the keys update as expected. Write-up for the docs looks good as well. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! I imagine the INSTALL.md will eventually get updated later by #980. This one should take priority, since main needs it.
|
Testing this fully requires that I brick my database, so I'll test some other PRs first and circle back to this one! |
im praying it works