-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acm dev cards #717
Merged
Merged
Acm dev cards #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and some formatting changes
smalex-z
force-pushed
the
acm-dev-cards
branch
8 times, most recently
from
October 11, 2024 08:01
93f9148
to
e93c66c
Compare
smalex-z
force-pushed
the
acm-dev-cards
branch
2 times, most recently
from
October 15, 2024 07:08
9b46e31
to
f7a884e
Compare
smalex-z
force-pushed
the
acm-dev-cards
branch
from
October 15, 2024 07:10
f7a884e
to
e599143
Compare
smalex-z
force-pushed
the
acm-dev-cards
branch
from
October 15, 2024 20:53
debfb7d
to
bc106a6
Compare
CSS has been updated to make everything more clear and viewable. Additionally grid view for tablets should look better now with some JS and CSS changes. Description box for projects supports in-line HTML too now. Try to keep each line to 100 characters max for readability |
snigdha-kansal
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ACM Dev Team Projects are now displayed as cards rather than text form. Hovering over the cards (or tapping them on mobile) shows information about the project, including the main language and the project & repo links.
Projects and Advisor cards updated as well. Project data is stored in /data/dev.js with the (now depreciated) officer data- if needed, we can update the data to be scraped from a Google Sheets like the officer data (officer-parser.mjs).
Fixes #113
Type of change
How Has This Been Tested?
Tested across all common desktop resolutions as well as some tablet and mobile resolutions.