Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acm dev cards #717

Merged
merged 16 commits into from
Nov 2, 2024
Merged

Acm dev cards #717

merged 16 commits into from
Nov 2, 2024

Conversation

smalex-z
Copy link
Contributor

@smalex-z smalex-z commented Oct 9, 2024

Description

ACM Dev Team Projects are now displayed as cards rather than text form. Hovering over the cards (or tapping them on mobile) shows information about the project, including the main language and the project & repo links.

Projects and Advisor cards updated as well. Project data is stored in /data/dev.js with the (now depreciated) officer data- if needed, we can update the data to be scraped from a Google Sheets like the officer data (officer-parser.mjs).

image
image

Fixes #113

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested across all common desktop resolutions as well as some tablet and mobile resolutions.

@smalex-z smalex-z force-pushed the acm-dev-cards branch 8 times, most recently from 93f9148 to e93c66c Compare October 11, 2024 08:01
@smalex-z smalex-z marked this pull request as draft October 15, 2024 06:44
@smalex-z smalex-z force-pushed the acm-dev-cards branch 2 times, most recently from 9b46e31 to f7a884e Compare October 15, 2024 07:08
@smalex-z smalex-z marked this pull request as ready for review October 15, 2024 20:57
data/dev.js Outdated Show resolved Hide resolved
pages/dev.js Outdated Show resolved Hide resolved
data/dev.js Outdated Show resolved Hide resolved
data/dev.js Outdated Show resolved Hide resolved
data/dev.js Outdated Show resolved Hide resolved
pages/dev.js Outdated Show resolved Hide resolved
pages/dev.js Outdated Show resolved Hide resolved
data/dev.js Outdated Show resolved Hide resolved
data/dev.js Outdated Show resolved Hide resolved
data/dev.js Outdated Show resolved Hide resolved
@smalex-z
Copy link
Contributor Author

CSS has been updated to make everything more clear and viewable. Additionally grid view for tablets should look better now with some JS and CSS changes. Description box for projects supports in-line HTML too now. Try to keep each line to 100 characters max for readability

Copy link
Contributor

@snigdha-kansal snigdha-kansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GIF

Looks great, Alex 💯
Thanks so much for doing this!!

Note: The font size change is a bit abrupt (goes from very large to very small) around 767-768px -- something to fix later.

@smalex-z smalex-z merged commit 70dfb79 into main Nov 2, 2024
8 checks passed
@smalex-z smalex-z deleted the acm-dev-cards branch November 2, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Team Page Projects
2 participants