Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes map when vw < 600px #728

Merged
merged 5 commits into from
Nov 5, 2024
Merged

removes map when vw < 600px #728

merged 5 commits into from
Nov 5, 2024

Conversation

smalex-z
Copy link
Contributor

@smalex-z smalex-z commented Oct 30, 2024

Describe your changes

Hides the embedded Google Maps on the GM page when VW < 600px. This will keep the page responsive and prevent stretching.

Issue ticket number and link

Fixes Issue #721

Checklist before requesting a review

  • I have performed a self-review of my code

Copy link
Contributor

@snigdha-kansal snigdha-kansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we still want users to be able to see the map on mobile view.
A better solution would be to make the display responsive, if possible.

@snigdha-kansal
Copy link
Contributor

Can we maintain the use of single quotes for consistency? Thanks

@smalex-z
Copy link
Contributor Author

smalex-z commented Nov 2, 2024

Can we maintain the use of single quotes for consistency? Thanks

done

pages/gm.js Outdated Show resolved Hide resolved
pages/gm.js Outdated Show resolved Hide resolved
Copy link
Contributor

@yeadamk yeadamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smalex-z smalex-z merged commit 05849ec into main Nov 5, 2024
8 checks passed
@smalex-z smalex-z deleted the GM-responsive branch November 5, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants