Merged
Conversation
Faizal-Eeman
approved these changes
Jul 8, 2025
Contributor
Faizal-Eeman
left a comment
There was a problem hiding this comment.
Sorry I missed this PR. Looks good to me.
The docker release date may need an update.
There was a problem hiding this comment.
Pull Request Overview
Updates BCFtools Docker image from version 1.21 to 1.22, following standard versioning practices and updating all relevant documentation files.
- Updated BCFtools version from 1.21 to 1.22 across all configuration files
- Added changelog entry documenting the version update
- Maintained consistency across metadata, documentation, and build configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| metadata.yaml | Updated version field to reflect BCFtools 1.22 |
| README.md | Updated version table to show BCFtools 1.22 |
| Dockerfile | Updated BCFTOOLS_VERSION build argument to 1.22 |
| CHANGELOG.md | Added new release entry for version 1.22 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+12
to
+13
| ## [1.22] - 2024-08-29 | ||
| - Update BCFtools 1.21 to 1.22 |
There was a problem hiding this comment.
[nitpick] The changelog entry format should be consistent with existing entries. Consider using 'Update BCFtools from 1.21 to 1.22' to match the pattern used in line 16.
Suggested change
| ## [1.22] - 2024-08-29 | |
| - Update BCFtools 1.21 to 1.22 | |
| - Update BCFtools from 1.21 to 1.22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating to the latest version
Closes #27
Testing Results
Docker Image Testing
Checklist
Formatting
I have read the code review guidelines and the code review best practice on GitHub check-list.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
File Updates
I have ensured that the version number update follows the versioning standards.
I have updated the version number in the
Dockerfile,README.mdandmetadata.yamlfiles.I have updated the dependencies and added my name to the maintainer list in the
Dockerfile.I have updated the feature changes in the
README.md(optional).I have added the changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.GitHub Packages Auto Build Rules
I have not manually pushed this Docker image to the uclahs-cds container registry (
ghcr.io/uclahs-cds) on GitHub.I have updated the
image_namein themetadata.yamlwhich is required by GitHub action to automatically build and push the image.