-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release docker-Battenberg v2.2.9
#11
Conversation
Looks good. Did you want to enable GitHub discussions and update the README using the latest template? https://github.com/uclahs-cds/template-docker Also, we want to use |
Added Discussion and updated README.
/hot/software/image/docker-Battenberg/Docker/development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few minor suggestions but otherwise looks good to me. Anything else to add @yashpatel6 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment but otherwise looks good!
Description
PR to release docker-Battenberg image
v2.2.9
.README updated with Battenberg GRCh37 and GRCh38 resources on the cluster.
Closes #10
Testing Results
Docker Image Testing
docker run
command as described below.Test Cases from PR #9
Checklist
Formatting
I have read the code review guidelines and the code review best practice on GitHub check-list.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
File Updates
I have ensured that the version number update follows the versioning standards.
I have updated the version number in the
Dockerfile
,README.md
andmetadata.yaml
files.I have updated the dependencies and added my name to the maintainer list in the
Dockerfile
.I have updated the feature changes in the
README.md
(optional).I have added the changes included in this pull request to the
CHANGELOG.md
under the next release version or unreleased, and updated the date.GitHub Packages Auto Build Rules
I have not manually pushed this Docker image to the uclahs-cds container registry (
ghcr.io/uclahs-cds
) on GitHub.I have updated the
image_name
in themetadata.yaml
which is required by GitHub action to automatically build and push the image.