Skip to content

Conversation

@alkaZeltser
Copy link
Collaborator

  • Added toggle from scatterplot to hexbinplot in create.pgs.with.continuous.phenotype.plot
  • Added option to include origin in axes for same plot
  • Added tests

Closes #26

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added the changes included in this pull request to NEWS under the next release version or unreleased, and updated the date.

  • I have updated the version number in metadata.yaml and DESCRIPTION.

  • Both R CMD build and R CMD check run successfully.

Closes #...

Testing Results

Case 1

input code
output

Case 2

input code
output

Copy link

@rachelmadang rachelmadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alkaZeltser alkaZeltser merged commit 81ce1d9 into main Feb 25, 2025
6 checks passed
@alkaZeltser alkaZeltser deleted the nzeltser-add-hexbin branch February 25, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scatterplot to Hexbinplot switch

3 participants