Skip to content

Conversation

@whelena
Copy link
Collaborator

@whelena whelena commented Jan 23, 2026

Description

Minor changes to pass devtools::check()

Checklist

  • This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
    Disclosing PHI is a major problem1 - Even a small leak can be costly2.

  • This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.

  • This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.

  To automatically exclude such files using a .gitignore file, see here for example.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Footnotes

  1. UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records

  2. The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records.

  3. Genetic information is considered PHI.
    Forensic assays can identify patients with as few as 21 SNPs

  4. RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request makes minor fixes to ensure the package passes devtools::check() validation. The changes correct vignette configuration, standardize graphics function parameter names, rename internal helper functions, and add missing package imports.

Changes:

  • Updated vignette engine specification and output format for consistency
  • Corrected parameter names in graphics device functions to match R documentation
  • Renamed internal angle calculation functions for clarity
  • Added missing package imports to NAMESPACE

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
vignettes/ManuscriptFigures.Rmd Updated vignette engine to knitr::rmarkdown and changed output format to html_document for consistency with other vignettes
R/save.plot.R Corrected parameter names from file to filename for png(), tiff(), and svg() functions to match R documentation
R/angles.R Renamed internal functions split.equal.angle and split.equal.x.dist to divide.equal.angle and divide.equal.x.dist
NAMESPACE Added missing imports: tail from utils, rnorm and runif from stats, and rgb from grDevices

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@tnyamaguchi tnyamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tnyamaguchi tnyamaguchi merged commit a9fd1be into main Jan 23, 2026
13 checks passed
@tnyamaguchi tnyamaguchi deleted the hwinata-pass-CRAN-checks branch January 23, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants