Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action for pytest #59

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Add GitHub action for pytest #59

merged 9 commits into from
Jan 12, 2024

Conversation

nwiltsie
Copy link
Member

@nwiltsie nwiltsie commented Jan 12, 2024

Description

As it says in the title. I will remember to run unit tests roughly 10% of the time and so our wonderful mechanical overlords at GitHub should do it for me.

The action YAML is based on GitHub's example.

There are at least two highly-starred public actions that would let us do something interesting with the test results (EnricoMi/publish-unit-test-result-action and mikepenz/action-junit-report), but as any action would require write permissions I'm choosing to defer on that for now.

I did have to add a requirements.txt file and I'm pretty rusty at python packaging - @aholmes would you mind sanity-checking me?

Checklist

  • This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
    Disclosing PHI is a major problem1 - Even a small leak can be costly2.

  • This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.

  • This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.

  To automatically exclude such files using a .gitignore file, see here for example.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Footnotes

  1. UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records

  2. The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records.

  3. Genetic information is considered PHI.
    Forensic assays can identify patients with as few as 21 SNPs

  4. RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.

@nwiltsie nwiltsie marked this pull request as ready for review January 12, 2024 17:47
requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If no concerns from @aholmes

@nwiltsie nwiltsie merged commit 24eefac into main Jan 12, 2024
2 checks passed
@nwiltsie nwiltsie deleted the nwiltsie-add-test-action branch January 12, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants