[OS-1380] Prevent to create several papers of the same type

forms/training/activity.py

@@ -833,6 +833,21 @@ class Meta:
             'ects': forms.NumberInput(attrs={'min': '0', 'step': '0.5'}),
         }
 
+    def __init__(self, parcours_doctoral: ParcoursDoctoral, *args, **kwargs):
+        super().__init__(parcours_doctoral, *args, **kwargs)
+
+        # Only one paper of each type can be created
+        paper_qs = parcours_doctoral.activity_set.filter(category=CategorieActivite.PAPER.name)
+
+        if self.instance:
+            paper_qs = paper_qs.exclude(type=self.instance.type)
+
+        unavailable_papers_types = paper_qs.values_list('type', flat=True)
+
+        self.fields['type'].choices = (
+            (enum.name, enum.value) for enum in ChoixTypeEpreuve if enum.name not in unavailable_papers_types
+        )
+
 
 class UclCourseForm(ActivityFormMixin, forms.ModelForm):
     template_name = "parcours_doctoral/forms/training/ucl_course.html"

locale/en/LC_MESSAGES/django.po

@@ -140,6 +140,9 @@ msgstr ""
 msgid "A non doctor member must have a justification."
 msgstr ""
 
+msgid "A paper of each type has already been created."
+msgstr ""
+
 msgid "A promoter can not be president."
 msgstr ""
 

locale/fr_BE/LC_MESSAGES/django.po

@@ -184,6 +184,9 @@ msgid "A non doctor member must have a justification."
 msgstr ""
 "Un membre non porteur du titre de docteur doit avoir une justification."
 
+msgid "A paper of each type has already been created."
+msgstr "Une épreuve de chaque type a déjà été créée."
+
 msgid "A promoter can not be president."
 msgstr "Un promoteur ne peut pas être président."
 

templates/parcours_doctoral/forms/training/paper.html

@@ -36,8 +36,14 @@ <h2>
 
 <p>{% lorem %}</p>
 
-<div class="row">
-  {% bootstrap_field form.type wrapper_class="form-group col-md-4 required_field" %}
-  {% bootstrap_field_with_tooltip form.ects classes="form-group col-md-4 required_field" %}
-</div>
-{% bootstrap_field form.comment %}
+{% if form.fields.type.choices %}
+  <div class="row">
+    {% bootstrap_field form.type wrapper_class="form-group col-md-4 required_field" %}
+    {% bootstrap_field_with_tooltip form.ects classes="form-group col-md-4 required_field" %}
+  </div>
+  {% bootstrap_field form.comment %}
+{% else %}
+  <div class="alert alert-danger">
+    {% translate 'A paper of each type has already been created.' %}
+  </div>
+{% endif %}

tests/views/cdd/test_training.py

@@ -28,9 +28,6 @@
 from unittest.mock import patch
 
 import freezegun
-from base.tests.factories.academic_year import AcademicYearFactory
-from base.tests.factories.learning_unit_year import LearningUnitYearFactory
-from base.tests.factories.program_manager import ProgramManagerFactory
 from django.conf import settings
 from django.forms import Field
 from django.shortcuts import resolve_url
@@ -41,9 +38,13 @@
 from osis_notification.models import WebNotification
 from rest_framework import status
 
+from base.tests.factories.academic_year import AcademicYearFactory
+from base.tests.factories.learning_unit_year import LearningUnitYearFactory
+from base.tests.factories.program_manager import ProgramManagerFactory
 from parcours_doctoral.ddd.formation.domain.model.enums import (
     CategorieActivite,
     ChoixComiteSelection,
+    ChoixTypeEpreuve,
     ContexteFormation,
     StatutActivite,
 )
@@ -241,6 +242,67 @@ def test_ucl_course(self):
         just_created = Activity.objects.first()
         self.assertEqual(just_created.context, ContexteFormation.COMPLEMENTARY_TRAINING.name)
 
+    def test_paper(self):
+        create_url = resolve_url(
+            f'parcours_doctoral:doctoral-training:add',
+            uuid=self.parcours_doctoral.uuid,
+            category=CategorieActivite.PAPER.name,
+        )
+
+        # No paper has been created -> all types are available
+        response = self.client.get(create_url)
+
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+        form = response.context['form']
+
+        self.assertCountEqual(form.fields['type'].choices, ((enum.name, enum.value) for enum in ChoixTypeEpreuve))
+
+        # Create a confirmation paper
+        response = self.client.post(
+            create_url,
+            data={
+                'type': ChoixTypeEpreuve.CONFIRMATION_PAPER.name,
+                'ects': 10,
+                'comment': 'comment A',
+            },
+        )
+
+        self.assertEqual(response.status_code, status.HTTP_302_FOUND)
+
+        just_created = Activity.objects.first()
+
+        self.assertEqual(just_created.context, ContexteFormation.DOCTORAL_TRAINING.name)
+        self.assertEqual(just_created.type, ChoixTypeEpreuve.CONFIRMATION_PAPER.name)
+        self.assertEqual(just_created.ects, 10)
+        self.assertEqual(just_created.comment, 'comment A')
+
+        # A confirmation paper has been created -> its type is not available anymore for another paper
+        response = self.client.get(create_url)
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+        form = response.context['form']
+
+        self.assertCountEqual(
+            form.fields['type'].choices,
+            ((enum.name, enum.value) for enum in [ChoixTypeEpreuve.PRIVATE_DEFENSE, ChoixTypeEpreuve.PUBLIC_DEFENSE]),
+        )
+
+        # A confirmation paper has been created -> its type is available if we want to edit it
+        update_url = resolve_url(
+            'parcours_doctoral:doctoral-training:edit',
+            uuid=self.parcours_doctoral.uuid,
+            activity_id=just_created.uuid,
+        )
+
+        response = self.client.get(update_url)
+
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+        form = response.context['form']
+
+        self.assertCountEqual(form.fields['type'].choices, ((enum.name, enum.value) for enum in ChoixTypeEpreuve))
+
     def test_missing_form(self):
         add_url = resolve_url(f'{self.namespace}:add', uuid=self.parcours_doctoral.uuid, category='foobar')
         response = self.client.get(add_url)
@@ -261,10 +323,14 @@ def test_parent(self):
         response = self.client.get(f"{add_url}?parent={self.conference.uuid}")
         self.assertEqual(response.status_code, status.HTTP_200_OK)
 
-        response = self.client.post(f"{add_url}?parent={self.conference.uuid}", {
-            'start_date_year': self.conference.start_date.year,
-            'start_date_month': self.conference.start_date.month,
-        }, follow=True)
+        response = self.client.post(
+            f"{add_url}?parent={self.conference.uuid}",
+            {
+                'start_date_year': self.conference.start_date.year,
+                'start_date_month': self.conference.start_date.month,
+            },
+            follow=True,
+        )
         self.assertEqual(response.status_code, status.HTTP_200_OK)
 
     def test_edit(self):