-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Stock Market Module #67
Open
SSingum
wants to merge
49
commits into
ufosc:feature/stocks
Choose a base branch
from
ssundal:main
base: feature/stocks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+624
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng time. Want to make it so the minutes update like a stopwatch instead of just in 12 minute increments
# Conflicts: # to_do.txt
…t how to run it alongside market time and when to start giving prompts to user (limit and stoploss implementation tbd)
…ng for left right display of stocks/portfolio.
…o be printed to the terminal
…her threads are not being written over
…heses issue, got keyboard text to print in the correct place using ascii, fixed random printing of x-axis in incorrect location
…py, cleaned up stock_market.py
…menu show up so everything is in a compact design that will fit in the module size requirements), also incorporated ANSI escape codes for majority of functions to ensure a standardized placement of each line (select_stock and display_graph functions need ANSI implementation to ensure proper printing for full functionality), need to work on removing global variables, and need to finish implementation of the buy, sell, and display graph feature.
…e terminal. Now we need to remove global variables.
… displayed three for each column. Portfolio display now includes total value of portfolio and the equity value for each of the stocks the player has in their portfolio. ALL GLOBAL VARIABLES REMOVED. The global variables are now included in the portfolio class (potential future changes could be to create a new class solely for those variables but everything does currently function as expected).
…to be fixed (select a stock disappears and screen pauses but prices are still updating in the background)
…re you can use g to switch between the graphs of stocks and the y-axis values update for each graph. Still need to test to make sure the displayed price is accurate.
…r a stock cannot be displayed unless the user first hits enter to select that stock and then g to display that stock's graph
…e no longer spaces in between)
…ized the components of the graph so different parts are printed separately from other parts of the graph. The prices on the y-axis are now fixed unless max/min is greater than or less than the top or bottom price, functioning like a real stock graph for the stock market.
-A player can now only own 5 stocks at a time
…ld in the portfolio and the display remains within the bounds allowed for the stock module
…t a gain/loss percent amount for each position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating the stock market module into the rest of Terminal Monopoly. See the commit history.