-
Notifications
You must be signed in to change notification settings - Fork 271
restart_fh from startTime #2766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
restart_fh from startTime #2766
Conversation
@junwang-noaa @DeniseWorthen This restart_fh from startTime works as expected in cpld_control_gfsv17 and restart. If this looks ok, I can open subcomponent PRs |
@NickSzapiro-NOAA - This will require updates to the global-workflow, which has gone through many updates to ensure it's generating the correct restart times for restart runs, with or without IAU, etc. Can you create an issue in global-workflow to make sure people know that updating to this version of the model will require updates or things will break there? |
@NickSzapiro-NOAA This is great! Would you please create a UWM issue first and then a G-W issue that links to the UWM issue? Using startTime as the base, it can simplify the forecast computation with or without IAU. I will create an FV3 PR and you can link with that in your UFS WM PR, then we can use restart_fh to define restart_interval and restart_interval can be removed from the model_configure (e.g. restart_internval will not be used even it shows up in model_configure) |
@NickSzapiro-NOAA I added the fv3atm changes in my branch: https://github.com/junwang-noaa/fv3atm/tree/uppfreq.
|
fyi @junwang-noaa , on hera many tests are timing out. I don't know if hera is just particularly slow the past couple days. There are also diffs in sfcf024.nc and GFSPRS.GrbF24 for cpld_control_gfsv17_iau_intel and cpld_control_gfsv17_nowav_iau_intel, like:
|
@NickSzapiro-NOAA Do you have a status update on this PR? |
Hi @gspetro-NOAA. It seems there may still be some issue with prate_ave NOAA-EMC/GFS#1 For restart_fh, my impression was that global-workflow didn't want this in ATM until after GFS.v17 retrospectives start...so we don't take developer time changing/checking changing from restart_interval. Is that right @JessicaMeixner-NOAA @dpsarmie ? |
Does this PR fix the prate_ave issue? If so, can you sync up all the branches and I'll start a test to confirm from the workflow, as we will need to fix prate_ave issue. |
No @JessicaMeixner-NOAA , this doesn't fix prate_ave. This is for components to use restart_fh (instead of restart_interval in ATM). It was blocked since prate_ave and cprat_ave changed answers and this is supposed to be bit-for-bit |
Commit Queue Requirements:
Description:
Currently, restart_fh is based on ESMF_ClockGet(clock, currTime=mcurrtime)+ESMF_TimeIntervalSet(s=fh_s) where currTime in ESMF clock at first timestep has already been adjusted by fhrot in UFS driver:
https://github.com/ufs-community/ufs-weather-model/blob/develop/driver/UFS.F90#L369-L377
So, for say a control run and its restart offset by fhrot, restart_fh entries in model_configure need to differ on continuation to write restarts at the same "calendar date" or "forecast hour wrt start time."
For example, currently with restart_fh: 2 3 7 11 13 15 for cpld_control_gfsv17 and cpld_restart_gfsv17 restarts are written at:
By referencing restart_fh from startTime instead, the same attribute matches for each.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: