Add -check all and -ftrapuv to all Intel DEBUG builds

[BrianCurtis-NOAA]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on Ursa
• Commit 'test_changes.list' from previous step

---

Description:

Bring in NCO requirements for DEBUG builds.

Commit Message:

* UFSWM - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * LM4-driver - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics -

Priority:

• Normal

Git Tracking

UFSWM:

• Closes Add -check all -check noarg_temp_created -ftrapuv to all DEBUG build flags of UFSWM and subcomponents #2023

Sub component Pull Requests:

• UFSATM:Bring in NCO Intel DEBUG build changes. NOAA-EMC/ufsatm#985
  • atmos_cubed_sphere: Bring in -check all and -ftrapuv to DEBUG intell builds NOAA-GFDL/GFDL_atmos_cubed_sphere#386
  • UPP: Bring in -check all and -ftrapuv to DEBUG intelllvm builds NOAA-EMC/UPP#1256
• GOCART: Bring in nco changes for DEBUG intel flags GEOS-ESM/GOCART#342
• LM4-driver: NCO changes for intel DEBUG flags NOAA-GFDL/LM4-NUOPC-driver#2
• WW3: Bring in nco DEBUG flag changes for ops NOAA-EMC/WW3#1455
• fire_behavior: Update CMakeLists with -check noarg_temp_created NOAA-EMC/fire_behavior#1
• stochastic_physics: Bring in nco DEBUG flag change for ops NOAA-PSL/stochastic_physics#86

UFSWM Blocking Dependencies:

• Update GOCART to v2.4.3 #2819
  One this goes through, this PR should not change baselines.
• Sync WW3 develop -> dev/ufs-weather-model  #2841

Documentation:

• No documentation update is required for this PR (please explain).

---

Changes

Regression Test Changes (Please commit test_changes.list):

• Baseline Updates. (bump to latest GOCART changes cpld/atmaero baselines for tracer fields)

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[BrianCurtis-NOAA]

Currently my test_changes.list is similar to #2819 to which I have the same changes. Once that PR goes through, this should not change baselines. That's my only blocker at this point.

[BrianCurtis-NOAA]

Also to note the WW3 changes are going to be merged after this PR, in a PR bringing in a merge from WW3 develop.

[DusanJovic-NOAA]

I've noticed that some components are being compiled without -check nopointer, which means pointer checks are enabled. However, other components are compiled with -check nopointer, which disables these checks. I think it's important to keep pointer checks enabled across all components.

[BrianCurtis-NOAA]

@DusanJovic-NOAA right, I wanted the scope of this PR to make sure those options were added. I assume removing -check nopointer would bring out numerous build failures or a mass amount of warnings. As such would be good for a different PR.

[JessicaMeixner-NOAA]

@BrianCurtis-NOAA The WW3 update that includes this is in UFS PR: #2841 NOAA-EMC/WW3#1480

[gspetro-NOAA]

UPDATE: It looks like adding the flags -shared-intel -diag-disable=10444 will solve the errors we were seeing in UPP PR #1256 on Ursa LLVM. Once @BrianCurtis-NOAA makes that update in UPP PR #1256, we can process that PR quickly on the UPP side. Then the UPP hash in FV3 PR #985 will need to be updated, and possibly the same fix applied to other dependent PRs if the same errors appear in those repos with Ursa LLVM.

EDIT: UPP PR #1256 has been merged!

[BrianCurtis-NOAA]

I added a blocking dep on #2841

[gspetro-NOAA]

@BrianCurtis-NOAA Do you have a status update/timeline on this PR?

[BrianCurtis-NOAA]

@BrianCurtis-NOAA Do you have a status update/timeline on this PR?

This one is basically ready to go. There's so many moving part's I'll try to hold off on a mass sync to day before this is ready for top of the queue.

[gspetro-NOAA]

@BrianCurtis-NOAA Will you hold off on pushing the log till then, too?

[gspetro-NOAA]

@BrianCurtis-NOAA Is this PR about ready to schedule? It looks like the fire_behavior and stochastic_physics sub-PRs need approval, but other than that and resolving conflicts, it seems ready to schedule.

[BrianCurtis-NOAA]

@BrianCurtis-NOAA Is this PR about ready to schedule? It looks like the fire_behavior and stochastic_physics sub-PRs need approval, but other than that and resolving conflicts, it seems ready to schedule.

Yes, it's ready to be scheduled, hopefully persistence is key to these subcomponent PR approvals, i fear for what merge day will be like