-
Notifications
You must be signed in to change notification settings - Fork 271
Bring CDEPS Inline capability to FV3 #2807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Bring CDEPS Inline capability to FV3 #2807
Conversation
Thank you @uturuncoglu! I am still catching up but I do see some reshape calls that may be important for GFS_coupling --> CCPP variables: If I understand, maybe it is worth checking what lat,lon from FV3 mesh look like if passed over to CCPP in same way |
@NickSzapiro-NOAA I think the issue is solved when I make change in the standard names after @DusanJovic-NOAA suggestion. At this point I am not sure what is the difference between |
@NickSzapiro-NOAA @junwang-noaa @DeniseWorthen It seems issue is fixed. @DusanJovic-NOAA Thanks again for your great help. Please see the latest comment in NOAA-EMC/ufsatm#988. Let me know if you want me to change those PRs ready to view. |
Just let me know if you also want me to include a new RT that demonstrates the capability. |
@junwang-noaa @DeniseWorthen @NickSzapiro-NOAA JFYI, I'll add a new RT (regional - RRFS_CONUScompact_13km, updates GL SST and ice conditions) to demonstrate the capability and this PR will be ready to review and merge. The test is created with SRW app. |
I think I could modify existing |
@gspetro-NOAA Okay. It was challenging since FV3 renamed as UFSATM now but synced now. I am starting to test and push the log files when it is done. |
@gspetro-NOAA I have just push the log file. RTs are fine on Hercules. |
@gspetro-NOAA BTW, I need to run the new test on Derecho (input files are staged in there) to be sure it is still working fine. |
@gspetro-NOAA I am getting following error when I try to compile new RT (conus13km_gl_inline) on Derecho,
This was working fine in the past. Let me know what you think? I could also copy input files to Hercules and try over there. |
@uturuncoglu At the moment, we are not running RTs on Derecho until PR #2863 goes through to fix a number of issues. If you can test on Hercules, that will speed things up. Otherwise, we may have to view #2863 as a dependency. @jkbk2004 Anything to add? |
@gspetro-NOAA Okay. I'll test on Hercules and update you. Copying required files now. |
@gspetro-NOAA Okay. The case is working fine on Hercules. The only issue that I noticed. The RT system assigning wrong number of processor to component (assigning 85 core to FV3 but layout was 12x12 in input.nml). So, I had to manually edit processor counts in config files. This was working fine on Derecho. I wonder if something changed in UFS WM model side. Any idea? |
@gspetro-NOAA Okay. I found the issue and will be fix soon. I was getting input.nml from INPUT directory to make it simple but I might need to define a template for it. |
@gspetro-NOAA I also fixed the test. So, it is ready in my end. |
Great! Could you push your logs from your test run? |
@gspetro-NOAA I have already pushed the test change list. Let me know if you want mw to push the logs too. |
@uturuncoglu Yes, ideally developers should push the logs, too, unless the changes are simple documentation/CI changes that don't affect source code. If you can do that and get the UFSATM subcomponent PR approved, then we can schedule this PR for the Commit Queue. |
@gspetro-NOAA Okay. That makes sense. Let me know which log file do I need to push. I could push |
@uturuncoglu Since you did your most recent testing on Hercules, you can push |
@uturuncoglu Just looking for a status update on this because I haven't seen any updates to the logs/test_changes.list. |
@gspetro-NOAA Let me push test change list and also |
@gspetro-NOAA Okay. I rerun all tests on Hercules and here is the failed tests,
I could not see anything particular in the log files and it seems |
Ok, thanks! If you can sync w/WM develop branch, I can finalize the test_changes.list stuff for you, and we can get this into the commit queue. :) |
@gspetro-NOAA Thanks. I have just sync the model. Let me know if you have any issues. |
Commit Queue Requirements:
Description:
This PR aims to bring CDEPS Inline capability to FV3 to allow updating desired fields in CCPP.
Some additional information:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
conus13km_gl_inline_intel
. It is based on conus13km grid but slightly different than the exiting configurations in terms ofinput.nml
. It basically update sea surface related variables (set, sea ice variables) over the Great Lakes using FVCOM forecast output.Input data Changes:
Library Changes/Upgrades:
Testing Log: