Tendency application update

[grantfirl]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

See https://docs.google.com/presentation/d/1LJbCrCVGYDvm0UPo8SR4KP6fT1VFocg-xLG399qGQ1w/edit?slide=id.g371ddcb3c06_0_238#slide=id.g371ddcb3c06_0_238 for a complete description.

Main points:

• Converts all primary schemes to return tendencies rather than modify the physics state
• Adds code to interstitial schemes to apply tendencies based on control from the host
• Other minor changes (including lots of metadata changes) to implement the above
• Obsolete schemes removed:
  • GFS_MP_generic_pre.F90
  • GFS_DCNV_generic_pre.F90
  • GFS_SCNV_generic_pre.F90
  • GFS_suite_stateout_reset.F90
  • GFS_suite_stateout_update.F90
  • mp_tempo_pre.F90
  • mp_thompson_pre.F90
• New schemes:
  • GFS_photochemistry_post.F90 (because there was no generic interstitial scheme for this to apply tendencies)
  • mynnedmf_wrapper_post.F90 (because it doesn't use GFS_PBL_generic_post.F90)

Commit Message:

* UFSWM - Physics tendency application changes
  * CMEPS - Physics tendency application changes 
  * FV3 - Physics tendency application changes
    * ccpp-physics - Physics tendency application changes

Priority:

• Normal

Git Tracking

UFSWM:

• None

Sub component Pull Requests:

• CMEPS:
• FV3: Tendency application update NOAA-EMC/ufsatm#989
  • ccpp-physics:Tendency application update ccpp-physics#299

UFSWM Blocking Dependencies:

• None

Documentation:

• No documentation update is required for this PR (please explain).

These changes are transparent for the user. Documentation changes on the CCPP component should be implemented to make sure that schemes follow the precedent set in this PR.

---

Changes

Regression Test Changes (Please commit test_changes.list):

• PR Updates/Changes Baselines.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[gspetro-NOAA]

@grantfirl Are there additional changes expected for this PR (other than conflict resolution), or should we be reviewing it for Commit Queue readiness?

[grantfirl]

@grantfirl Are there additional changes expected for this PR (other than conflict resolution), or should we be reviewing it for Commit Queue readiness?

@gspetro-NOAA EMC wants to wait until after GFSv17 operational implementation to review/merge this, so it won't be ready for the commit queue for a while.

[gspetro-NOAA]

@grantfirl Just checking in--is there a status update on this PR? It's been in draft for a while, so I just wanted to confirm that you're still planning to work on it.

[grantfirl]

@grantfirl Just checking in--is there a status update on this PR? It's been in draft for a while, so I just wanted to confirm that you're still planning to work on it.

Yes, indeed. I've been keeping this branch relatively up-to-date, but there are a few failing RTs that need to be fixed before removing the draft label. Even then, I think that EMC wants to do some more thorough testing to make sure that the result differences are below a threshold before merging.