Skip to content

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Jul 15, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

See https://docs.google.com/presentation/d/1LJbCrCVGYDvm0UPo8SR4KP6fT1VFocg-xLG399qGQ1w/edit?slide=id.g371ddcb3c06_0_238#slide=id.g371ddcb3c06_0_238 for a complete description.

Main points:

  • Converts all primary schemes to return tendencies rather than modify the physics state
  • Adds code to interstitial schemes to apply tendencies based on control from the host
  • Other minor changes (including lots of metadata changes) to implement the above
  • Obsolete schemes removed:
    • GFS_MP_generic_pre.F90
    • GFS_DCNV_generic_pre.F90
    • GFS_SCNV_generic_pre.F90
    • GFS_suite_stateout_reset.F90
    • GFS_suite_stateout_update.F90
    • mp_tempo_pre.F90
    • mp_thompson_pre.F90
  • New schemes:
    • GFS_photochemistry_post.F90 (because there was no generic interstitial scheme for this to apply tendencies)
    • mynnedmf_wrapper_post.F90 (because it doesn't use GFS_PBL_generic_post.F90)

Commit Message:

* UFSWM - Physics tendency application changes
  * CMEPS - Physics tendency application changes 
  * FV3 - Physics tendency application changes
    * ccpp-physics - Physics tendency application changes

Priority:

  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • No documentation update is required for this PR (please explain).

These changes are transparent for the user. Documentation changes on the CCPP component should be implemented to make sure that schemes follow the precedent set in this PR.


Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@gspetro-NOAA gspetro-NOAA added the Baseline Updates Current baselines will be updated. label Sep 17, 2025
@gspetro-NOAA
Copy link
Collaborator

@grantfirl Are there additional changes expected for this PR (other than conflict resolution), or should we be reviewing it for Commit Queue readiness?

@grantfirl
Copy link
Collaborator Author

grantfirl commented Sep 18, 2025

@grantfirl Are there additional changes expected for this PR (other than conflict resolution), or should we be reviewing it for Commit Queue readiness?

@gspetro-NOAA EMC wants to wait until after GFSv17 operational implementation to review/merge this, so it won't be ready for the commit queue for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated.

Projects

Status: On Pause

Development

Successfully merging this pull request may close these issues.

2 participants