-
Notifications
You must be signed in to change notification settings - Fork 271
Update SFS test to C192mx025; add debug and restart tests; update ultralow warmstart input to specify V2 file type. #2835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update SFS test to C192mx025; add debug and restart tests; update ultralow warmstart input to specify V2 file type. #2835
Conversation
This reverts commit 8e3253c.
These should be included in SFS RT since SFS are also using SPPTINT=SKEBINT=SHUMINT=0 as GEFS. |
Thanks @XiaqiongZhou-NOAA ! And the new_lscale = .true. also, right? |
SFS is using default new_lscale=.false, but I guess it is better to be consistent with GEFS. Please also include it as true. Thanks. |
note, the SPPT configuration is currently being tunned and the values will change in the future. |
@NeilBarton-NOAA Thanks. It is a moving target! I'd like to reproduce whatever is the current SFS "base" configuration for this initial commit. As you zero in on parameter sets etc, we can update the test. |
@NickSzapiro-NOAA The only @NeilBarton-NOAA @XiaqiongZhou-NOAA The RT can only really test the features that have been tested and are known/expected to be included in the SFS configuration. As new features and parameterizations/values are tested and confirmed in the science experiments, the test will update and also implement those features etc. But if these new stoch settings are still under evaluation in the SFS science side, then I'm not sure we want to update them in the test. |
We've haven't updated GEFS RT yet, including change of new_lscale=.true.. The code makes it seem that's more "proper" and should be used. I don't know if stochastic physics side has preference, when they can |
@gspetro-NOAA Is the project PR board being updated automatically yet? This PR is still shown as draft and that the pre-tests are not done. I've committed both the ursa log and the test change list and this PR has been open for the last 5 days. The issue in UFS-UTILS has been confirmed by others as non-impactful. |
We have tested new_lscale=.true.. in GEFS. For SFS, the default is to test with new_lscale=.true.. |
@DeniseWorthen The status update will likely have to be manual, but I have automated the labeling for baselines/input data based on labels we add to the PR. I am hoping to automate the priority labels and info about subcomponents involved, but that will have to wait till after my current work on the Runtime/Memory reporting/scorecard. I will bring this PR up at the WM CM meeting tomorrow to make sure we get the input data staged and this PR scheduled. I think the main holdup on the input data is just that we need to confer and agree on what date to use before we can stage it. |
Thanks @NeilBarton-NOAA I will add an issue to create a parsable variable and add it to the global nml template for use. |
@DeniseWorthen We will go with |
@DeniseWorthen I have rsync'd the new input data to:
I had to resolve some role account issues, hence the delay, but I'm hoping it should work as expected now! Let me know if there are any issues. |
@gspetro-NOAA There is an issue w/ missing links in the new input data
In the staged input, you'll see a set of files as links. These links need to be restored in the official input-data directory:
We also need to be sure the sym-links are maintained when you stage the new input-data on other platforms. But lets get Ursa fixed first. |
@DeniseWorthen I think I've added the symlinks properly now, but let me know if I missed anything. |
@gspetro-NOAA The input-data is now correct. The test list change is as expected (v2 tests, ultralow and sfs). The This PR is ready once the input-data has been added to all platforms. Thanks. |
Great! I will go ahead and add the input data onto other platforms! Then we can hopefully get this into the Commit Queue asap! |
Commit Queue Requirements:
Description:
Warmstarts for ICE and OCN are from
The ATM ICs are from
The ATM and OCN increment files are from
The fix files are identical to those in
For example, the oro files (e.g.
oro_data.tile1.nc
) used by the RT are source fromand these are identical to those in
role.glopara/fix/orog/20240917/C192/C192.mx025_oro_data.tile2.nc
However, the C192 grid files (eg
C192_grid.tile4.nc
) are not identical . In the RTs, these are source fromand these files have small round-off level differences w/ the grid files in
role.glopara/fix/orog/20240917/C192/
. I don't believe this is an issue unless an attempt is made to repro a G-W run and an RT run.Note that because the ATM is writing history files every 24 hours for the control test, the restart and debug tests compare only restart files from all components; the surface history files will not be B4B because the accumulated fields in the surface files will not be B4B.
At commit 3acafc1, this is the input.nml difference between the new
cpld_control_sfs
and the initial SFS sandbox provided. I've removed the differences in the fix files, which differ only the path-to-file.Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Baseline changes are due to
Pre-testing on C6 using a staged baseline for the ultralow and SFS test shows that:
Input data Changes:
This PR requires a NEW input-data directory to both add the files required for the new SFS test as well as fixing the ultralow staged input.
The NEW input-data directory is located on Ursa at
Library Changes/Upgrades:
Testing Log: