Skip to content

Conversation

KaiWang-NOAA
Copy link

@KaiWang-NOAA KaiWang-NOAA commented Sep 18, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on Ursa
  • Commit 'test_changes.list' from previous step

Description:

Update submodule pointer for AQM for the changes in NOAA-EMC/AQM#121 to bring in missing commits from production/AQM.v7 and reversed the Rsnow value for the AQMv8 development

Commit Message:

* UFSWM - 
  * AQM - Bring in additional changes from production/AQM.v7 and reversed the Rsnow value

Priority:

  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • No documentation update is required for this PR.

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@KaiWang-NOAA KaiWang-NOAA marked this pull request as ready for review September 18, 2025 17:43
@BrianCurtis-NOAA
Copy link
Collaborator

This looks good. Please run the full RT suite on Ursa to get a RegressionTests_ursa.log and a test_changes.list to push to this repo which will help verify that only the AQM tests are changing baselines, as stated in the template.

@BrianCurtis-NOAA BrianCurtis-NOAA added the Baseline Updates Current baselines will be updated. label Sep 18, 2025
@gspetro-NOAA gspetro-NOAA moved this to Evaluating in PRs to Process Sep 18, 2025
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Sep 18, 2025
@gspetro-NOAA gspetro-NOAA moved this from Pre-testing required to Review in PRs to Process Sep 29, 2025
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Sep 30, 2025
@gspetro-NOAA gspetro-NOAA added the On Deck This is the next PR in line for testing/merge. label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. On Deck This is the next PR in line for testing/merge.

Projects

Status: Schedule

Development

Successfully merging this pull request may close these issues.

3 participants