Skip to content

Conversation

pjpegion
Copy link
Collaborator

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Commit 'test_changes.list' (unless file is empty).
  • Fill out all sections of this template.

Description:

Commit Message:

* UFSWM - update submodule pointer
  * FV3 - update submodule pointer
    * atmos_cubed_sphere - zero out temporary arrays so SKEB will work when no vorticity damping

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal. we can work out of a branch for SFS developement in the meantime.

Git Tracking

UFSWM:

  • Closes #

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • New input data.
  • Updated input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@gspetro-NOAA gspetro-NOAA added the No Baseline Change No Baseline Change label Sep 24, 2025
@gspetro-NOAA gspetro-NOAA moved this to Evaluating in PRs to Process Sep 24, 2025
@gspetro-NOAA
Copy link
Collaborator

@pjpegion Is this PR ready to go? If so, you'll need to commit test_changes.list and new logs. Currently, test_changes.list shows a baseline change, and the logs show a failure, which shouldn't happen if there is no baseline change.

@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

Status: Pre-testing required

Development

Successfully merging this pull request may close these issues.

2 participants