-
Notifications
You must be signed in to change notification settings - Fork 271
variable gravity #2916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
variable gravity #2916
Conversation
@WChen-NOAA Could you fill out the PR template fully with information on baseline changes, input data, and so on? If you are still working on this PR and don't have the full details yet, that's fine, but I would just want to update the PR status appropriately in our tracker. |
@gspetro-NOAA Hi, Thank you for the suggestions. But this change has no baseline change and input data. Currently it works for upper atmosphere with whole atmosphere model (WAM). If for UFS-WM, the option needs to be set as false. And I will check the information again and fill out what I could do. |
@WChen-NOAA When you have a chance, please finish filling out the PR template, especially the "commit message" section. This PR will probably be on hold until after the shutdown because reviewers for atmos_cubed_sphere likely cannot review until then, but once we can get the subcomponent PRs reviewed and the PR template completed, this PR will be ready to schedule. |
Commit Queue Requirements:
Description:
Initial NOAA-GFDL/GFDL_atmos_cubed_sphere#394
The model uses the shallow atmosphere approximation with constant gravity.
This is problematic for a space weather model (WAM) where Ztop/r0 )~10%
The method to resolve this issue is to Implement a scaling factor wherever gravity is applied to account for variations with height:
g(r0/r)^2 while setting var_grav = .true. in the name list
The new gravity as grav_var(i,j,k)
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: