Skip to content

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Oct 2, 2025

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers. N/A
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Commit 'test_changes.list' (unless file is empty).
  • Fill out all sections of this template.

Description:

Adds a settable parameter for the HFREEZE value in MOM6.

Commit Message:

* UFSWM - Add a variable to set the hfreeze value for MOM6 input.

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Documentation:

  • Documentation update NOT required.
    • Explanation: No documentation current exists for the setting of MOM_input values; adding such documentation is beyond the scope of this PR

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • New input data.
  • Updated input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen DeniseWorthen self-assigned this Oct 2, 2025
@DeniseWorthen DeniseWorthen added the No Baseline Change No Baseline Change label Oct 2, 2025
@DeniseWorthen DeniseWorthen marked this pull request as ready for review October 2, 2025 18:45
@NickSzapiro-NOAA
Copy link
Collaborator

This PR looks good to me.

More of a question @DeniseWorthen @sanAkel . Do I understand correctly that if hfrz<h_ML then melt_potential increases linearly with this hfreeze parameter (as delT(i) = delT(i) + dh * (CS%tv%T(i,j,k) - T_freeze(i))?

Then 2 vs 20 vs ... seems arbitrary and would often be smaller than mixed layer depth and used in calculation of coupling variable to CICE, no?

@sanAkel
Copy link
Contributor

sanAkel commented Oct 3, 2025

This PR looks good to me.

More of a question @DeniseWorthen @sanAkel . Do I understand correctly that if hfrz<h_ML then melt_potential increases linearly with this hfreeze parameter (as delT(i) = delT(i) + dh * (CS%tv%T(i,j,k) - T_freeze(i))?

Then 2 vs 20 vs ... seems arbitrary and would often be smaller than mixed layer depth and used in calculation of coupling variable to CICE, no?

User specification of that parameter value makes sense to me too.

@DeniseWorthen
Copy link
Collaborator Author

Using the DATM RT test at 1/4deg OCN/ICE, I compared the current 20m default against 2m. After 5 days:

Screenshot 2025-10-03 at 1 20 23 PM

@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review in PRs to Process Oct 14, 2025
@gspetro-NOAA
Copy link
Collaborator

@DeniseWorthen Just checking in on this PR - the label says no baseline changes, but neither the baseline change info nor the input data info is filled out in the template, so just wanted to see if you could update that. Otherwise, it looks ready to schedule. Is that correct, or did you have any other additions planned?

@DeniseWorthen
Copy link
Collaborator Author

@gspetro-NOAA I've merge the latest develop and checked the remaining boxes. Thanks.

@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

Status: Schedule

Development

Successfully merging this pull request may close these issues.

Allow HFREEZE in MOM_input to be a settable parameter

4 participants