Skip to content

Conversation

zhanglikate
Copy link

@zhanglikate zhanglikate commented Oct 10, 2025

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

Commit Message:

* UFSWM - 

Priority:

  • High: Get grib2 output for GCAFS model

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@@ -0,0 +1,6 @@
&MODEL_INPUTS
MODELNAME='GFS'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be gcafs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modelname 'GFS' is used internally in UPP to specify global model processing schemes. It applies to GFS, GEFS, and GCAFS processing.

@gspetro-NOAA gspetro-NOAA added the No Baseline Change No Baseline Change label Oct 14, 2025
@gspetro-NOAA
Copy link
Collaborator

gspetro-NOAA commented Oct 14, 2025

@zhanglikate Could you fill out the Commit Message portion of the template, push your log file showing that you ran the full RT suite, and push your test_changes.list file?

@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

Status: Pre-testing required

Development

Successfully merging this pull request may close these issues.

4 participants