Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose rewrite issue 4488 #1227

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Expose rewrite issue 4488 #1227

wants to merge 3 commits into from

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Nov 12, 2024 •
edited
Loading

Expose openrewrite/rewrite#4488 in real project.

@uhafner uhafner added the bug Bugs or performance problems label Nov 12, 2024
Repository owner deleted a comment from codecov bot Nov 12, 2024
Repository owner deleted a comment from github-actions bot Nov 12, 2024
Repository owner deleted a comment from codecov bot Nov 12, 2024
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 98% successful (✔️ 96 passed, 🙈 2 skipped)
   〰️   Line Coverage: 91% (59 missed lines)
   ➰   Branch Coverage: 91% (19 missed branches)
   PIT   Mutation Coverage: 80% (77 survived mutations)
   💪   Test Strength: 84% (57 survived mutations in tested code)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilities
   🌀   Cyclomatic Complexity: 355 (total)
   💭   Cognitive Complexity: 172 (total)
   📏   Lines of Code: 3859 (total)
   📝   Non Commenting Source Statements: 1199 (total)
   🔭   Access to foreign data: 87 (total)
   🔗   Class cohesion: 71.43% (maximum)
   📤   Fan out: 224 (total)
   📲   Number of accessors: 14 (total)
   ⚖️   Weight of a class: 100.00% (maximum)
   📐   Weighted method count: 354 (total)
   ➿   N-Path Complexity: 432 (total)

Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result.

@uhafner uhafner changed the title Enable all files for rewrite Expose rewrite issue 4488 Nov 12, 2024
@uhafner uhafner marked this pull request as draft November 12, 2024 09:55
@uhafner uhafner mentioned this pull request Nov 12, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (17b4109) to head (fd08917).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1227   +/-   ##
=========================================
  Coverage     88.87%   88.87%           
  Complexity      164      164           
=========================================
  Files            11       11           
  Lines           683      683           
  Branches         85       85           
=========================================
  Hits            607      607           
  Misses           59       59           
  Partials         17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 12, 2024
View reviewed changes
src/test/java/edu/hm/hafner/util/ACTest.java

public abstract class ACTest<T extends Comparable<T>> {
void shouldBeNegativeIfThisIsSmaller() {
T smaller = createSmallerSut();

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'T smaller' is never read.
src/test/java/edu/hm/hafner/util/ACTest.java
public abstract class ACTest<T extends Comparable<T>> {
void shouldBeNegativeIfThisIsSmaller() {
T smaller = createSmallerSut();
T greater = createGreaterSut();

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'T greater' is never read.
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 98% successful (✔️ 96 passed, 🙈 2 skipped)
   〰️   Line Coverage: 91% (59 missed lines)
   ➰   Branch Coverage: 91% (19 missed branches)
   PIT   Mutation Coverage: 80% (77 survived mutations)
   💪   Test Strength: 84% (57 survived mutations in tested code)
   CheckStyle   CheckStyle: 1 warning (normal: 1)
   PMD   PMD: 2 warnings (normal: 2)
   SpotBugs   SpotBugs: 2 bugs (low: 2)
   🐛   Error Prone: 3 bugs (normal: 3)
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilities
   🌀   Cyclomatic Complexity: 355 (total)
   💭   Cognitive Complexity: 172 (total)
   📏   Lines of Code: 3859 (total)
   📝   Non Commenting Source Statements: 1199 (total)
   🔭   Access to foreign data: 87 (total)
   🔗   Class cohesion: 71.43% (maximum)
   📤   Fan out: 224 (total)
   📲   Number of accessors: 14 (total)
   ⚖️   Weight of a class: 100.00% (maximum)
   📐   Weighted method count: 354 (total)
   ➿   N-Path Complexity: 432 (total)

Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 98% successful (✔️ 96 passed, 🙈 2 skipped)
   〰️   Line Coverage: 91% (59 missed lines)
   ➰   Branch Coverage: 91% (19 missed branches)
   PIT   Mutation Coverage: 80% (77 survived mutations)
   💪   Test Strength: 84% (57 survived mutations in tested code)
   CheckStyle   CheckStyle: 1 warning (normal: 1)
   PMD   PMD: 2 warnings (normal: 2)
   SpotBugs   SpotBugs: 2 bugs (low: 2)
   🐛   Error Prone: 3 bugs (normal: 3)
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilities
   🌀   Cyclomatic Complexity: 355 (total)
   💭   Cognitive Complexity: 172 (total)
   📏   Lines of Code: 3859 (total)
   📝   Non Commenting Source Statements: 1199 (total)
   🔭   Access to foreign data: 87 (total)
   🔗   Class cohesion: 71.43% (maximum)
   📤   Fan out: 224 (total)
   📲   Number of accessors: 14 (total)
   ⚖️   Weight of a class: 100.00% (maximum)
   📐   Weighted method count: 354 (total)
   ➿   N-Path Complexity: 432 (total)

Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs or performance problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uhafner