Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for hhbtag #10

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Minor fixes for hhbtag #10

merged 5 commits into from
Aug 30, 2023

Conversation

haddadanas
Copy link
Contributor

resolving the issue, where the Selection would fail, due to weird effects caused by ?-type awkward arrays. This was implemented by using _ak.fill__none and ak.to_numpy

casted mask array and input features to numpy before evaluating the model, to prevent an TypeError by tensorflow and Prevented C++ Memory Corruption when filling the 'all_scores' awkward array
Copy link
Member

@riga riga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @haddadanas !

Thanks for the PR, looks very good 🎉

Just two minor things inline.

hbt/production/hhbtag.py Outdated Show resolved Hide resolved
hbt/selection/default.py Outdated Show resolved Hide resolved
haddadanas and others added 2 commits August 30, 2023 13:35
Copy link
Member

@riga riga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riga riga merged commit 10b11c2 into uhh-cms:master Aug 30, 2023
1 check passed
@haddadanas haddadanas deleted the hhbtag_awkward branch August 30, 2023 12:01
aalvesan pushed a commit that referenced this pull request Jan 31, 2024
Nano aod files uhh_v11_Run2_UL2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants