Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run 2 updates #22

Merged
merged 6 commits into from
Jun 11, 2024
Merged

run 2 updates #22

merged 6 commits into from
Jun 11, 2024

Conversation

nprouvost
Copy link
Contributor

No description provided.

@riga riga self-requested a review June 7, 2024 07:29
@riga riga self-assigned this Jun 7, 2024
@riga riga added the enhancement New feature or request label Jun 7, 2024
riga
riga requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@riga riga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @aalvesan and @nprouvost !

I had a couple minor comments that I made inline below.

Besides that, I'd like to suggest to move all inference related changes to a second PR. The code is essentially a drop-in from the hbw analysis but I think we should discuss their approaches first and see if they apply to our analysis.

hbt/calibration/default.py Outdated Show resolved Hide resolved
hbt/calibration/placeholder.py Outdated Show resolved Hide resolved
hbt/config/variables.py Outdated Show resolved Hide resolved
hbt/production/empty.py Outdated Show resolved Hide resolved
hbt/production/empty.py Outdated Show resolved Hide resolved
hbt/selection/empty.py Outdated Show resolved Hide resolved
hbt/selection/trigger.py Outdated Show resolved Hide resolved
hbt/production/hh_mass.py Outdated Show resolved Hide resolved
@nprouvost nprouvost requested a review from riga June 10, 2024 11:48
@riga riga changed the base branch from master to pre_run2_merge June 11, 2024 16:59
@riga riga merged commit f854eb8 into uhh-cms:pre_run2_merge Jun 11, 2024
1 check passed
@riga riga mentioned this pull request Jun 11, 2024
Merged
riga added a commit that referenced this pull request Jun 11, 2024
@riga @nprouvost
run 2 updates (#22 followup) (#24)
8ac24ab 
* run 2 updates (#22)

* run 2 updates

* implement changes recommended in PR

* implement changes demanded in PR number 2

---------

Co-authored-by: Marcel Rieger <[email protected]>

* Remove nocert config.

---------

Co-authored-by: Nathan Prouvost <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riga riga riga approved these changes

Assignees

@riga riga

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nprouvost @riga