V9 support linting + typing #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciolauffer
had a problem deploying
to
external
GitHub Actions
Failure
mauriciolauffer
had a problem deploying
to
external
GitHub Actions
Failure
|
I'll adjust Gh action test triggers asap so the full tests run on push |
* fix: performance * fix: improve error handling and result processing in executeControlMethod * fix: refactor executeObjectMethod not using callbacks * test: update DateTimePicker API test to use ISO string format * fix: update generated-methods test to handle different date formats based on protocol * fix: await browser.asControl in press test for proper asynchronous handling * fix: bidi race condition in retrieveElements * fix: update Planning Calendar test to handle BIDI-specific DOM controls * fix: optimize control retrieval for BIDI by removing unnecessary await * fix: adjust BIDI handling in exec test to avoid Promise.all for performance * chore: configuration * fix: add TODO comment for handling UI5 injection options * refactor: remove propietary waitForUI5 * refactor: run planningCalendar test also with BiDi protocol * fix: improve peformance while retrieving multiple elements (ui5-community#665) [skip ci] * refactor: rename clientSide__checkForUI5Ready to clientSide_checkForUI5Ready for consistency * chore: lock file * fix: test * refactor: rm unnecessary await --------- Co-authored-by: Volker Buzek <[email protected]>
mauriciolauffer
had a problem deploying
to
external
GitHub Actions
Failure
mauriciolauffer
had a problem deploying
to
external
GitHub Actions
Failure
mauriciolauffer
requested a deployment
to
external
GitHub Actions
Waiting
mauriciolauffer
requested a deployment
to
external
GitHub Actions
Waiting
mauriciolauffer
requested a deployment
to
external
GitHub Actions
Waiting
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
marianfoo
reviewed
Jul 1, 2025
vobu
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the work, mostly ESLint + TypeScript so far. No need to merge now, it's more for visibility and for you guys to review and tell me whether I'm on the write direction.