UI5 legacy free (v2?) #681
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciolauffer
requested a deployment
to
external
GitHub Actions
Waiting
mauriciolauffer
requested a deployment
to
external
GitHub Actions
Waiting
mauriciolauffer
requested a deployment
to
external
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI5 legacy free is now supported!
Dependency
dotenvhas been removed as WebdriverIO already import.envfiles. Calling it withinwdi5again was importing the files 2x.New test structure and patterns, I tried to standardize the NPM scripts. Starting a webserver should always be
start, executing the tests should always betestand a scriptstart:testshould execute both like this:run-p -r start test.If a package has more than one test, the script name should follow the pattern
test:something,test:elseand thetestone should execute all tests likerun-s test:**. An example can be found in examples/ui5-v2-js-app/package.json. I'll add it to the documentation.I haven't touched the
examples/ui5-ts-appor anything related to Docker yet as I'm afraid to break all the remote tests that I'm not familiar with.