Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the calculation of first wall geometry and area in the codebase. The logic for calculating the first wall's half-height and surface areas has been extracted from
process/build.pyand reimplemented in a more modular and testable way within a newFirstWallclass inprocess/fw.py. Additionally, the codebase is updated to useFirstWallinstead of the oldFwclass, and related variables are initialized and managed more cleanly. Associated tests and fixtures are updated to use the new class.Key changes include:
Refactoring and Code Organization
process/build.pyto new static methods in theFirstWallclass inprocess/fw.py, improving modularity and maintainability.Fwclass is replaced with the newFirstWallclass throughout the codebase, including inprocess/main.py, integration tests, and unit tests.Variable Initialization and Data Structure Updates
dz_fw_half) is added tofwbs_variablesand properly initialized inprocess/data_structure/fwbs_variables.py.Imports and Cleanup
process/build.py.These changes make the codebase cleaner, easier to test, and more maintainable by encapsulating first wall calculations in a dedicated class and updating all relevant usages.## Description
Checklist
I confirm that I have completed the following checks: