Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _client.py to allow server and port in the Client constructor #46

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adam-parker1
Copy link
Contributor

Simplify python client instance creation

pyuda.Client.server = 'my.server.hostname'
pyuda.Client.port = 56789
client = pyuda.Client()

Can now we replaced by

client = pyuda.Client('my.server.hostname', 56789)

add server and port to Client __init__ args so don't have to set with separate metaclass
@adam-parker1
Copy link
Contributor Author

Also, I think __metaclass__ = ClientMeta is redundant in _client.py if we are using six.with_metaclass(..)

@adam-parker1
Copy link
Contributor Author

If we are not targeting Python2 anymore, maybe we can replace the six.with_metaclass(....) with the standard metaclass(...) and remove the six dependency?

@adam-parker1 adam-parker1 marked this pull request as draft August 21, 2024 08:56
@adam-parker1
Copy link
Contributor Author

Review for UDA v3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant