Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nathan/deps in pyproject.toml #85

Merged
merged 31 commits into from
Oct 23, 2024
Merged

Nathan/deps in pyproject.toml #85

merged 31 commits into from
Oct 23, 2024

Conversation

NathanCummings
Copy link
Member

  • Used uv to add dependencies to pyproject.toml
  • Modified docker-compose.yml to build from pyproject.toml
  • Removed requirements.txt

@NathanCummings
Copy link
Member Author

OK, so the errors with the tests...

Have fixed some of them by fixing pandas to version 2.0.3. By 2.2.3 they had changed the order of the arguments for its sql builder functions.

@NathanCummings
Copy link
Member Author

The other tests were fixed by me including the pytest-benchmark plugin that was missing.

@jameshod5
Copy link
Collaborator

All the changes look good to me, the README will need to be updated for the changes though (whether in this PR or a new one)

@jameshod5 jameshod5 mentioned this pull request Oct 22, 2024
Closed
jameshod5
jameshod5 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@jameshod5 jameshod5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and have run through the installation instructions and all works well. Happy to merge but you mentioned you could remove uv sync from the CI to tidy it up?

@NathanCummings NathanCummings mentioned this pull request Oct 23, 2024
Closed
@NathanCummings NathanCummings merged commit f03c067 into main Oct 23, 2024
2 checks passed
@NathanCummings NathanCummings deleted the nathan/deps-in-pyproject.toml branch October 23, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshod5 jameshod5 jameshod5 approved these changes

@samueljackson92 samueljackson92 Awaiting requested review from samueljackson92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanCummings @jameshod5