Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial company name typeahead search using dnb microservice #7577

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DeanElliott96
Copy link
Contributor

@DeanElliott96 DeanElliott96 commented Feb 26, 2025

Description of change

Initial work from Spike to investigate if we can add a typeahead pointing at the dnb microservice when adding a new company.

Test instructions

What should I see?

Screenshots

Before

Add a screenshot

After

Screen.Recording.2025-02-26.at.09.10.47.mov

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

} else {
return Promise.resolve([])
}
}, 500)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is 500 here?

Copy link

cypress bot commented Feb 26, 2025

data-hub-frontend    Run #59468

Run Properties:  status check passed Passed #59468  •  git commit d314ac7f2e: Update proptypes
Project data-hub-frontend
Branch Review feature/TET-966-company-search-typeahead
Run status status check passed Passed #59468
Run duration 07m 58s
Commit git commit d314ac7f2e: Update proptypes
Committer Dean Elliott
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants