NOISSUE - Python runtime #137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SammyOina please resolve the conflicts |
Signed-off-by: SammyOina <[email protected]>
Enhanced the algorithm execution process by introducing a mechanism to handle additional requirements specified in a requirements.txt file. This change accommodates the need for algorithms to specify necessary dependencies, ensuring that the system installs them before executing the algorithm. The modifications affect the agent proto definition, gRPC layers, and the internal agent computation process. Consequently, this update demands corresponding client-side adjustments to provide the requirements file during algorithm upload. Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Changed the 'Result' RPC method to support server-side streaming, allowing results to be sent as a stream of messages. This enhances the ability to handle large data by breaking it down into chunks, reducing memory pressure and potentially improving performance for large result sets. Adapted server and client-side handling code to accommodate the streaming interface, including correct handling of message sending and receiving loops and EOF detection. Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
* refactor(cli): rename `logger` package import to `glogger` * refactor(cli): remove unused import of `github.com/google/logger` * refactor(cli): rename `logger` variable to `glogger` * refactor(server): remove unused `AuthUnaryInterceptor` from grpc server options * refactor(test): remove commented out code for `dataPath` variable in main function Signed-off-by: SammyOina <[email protected]>
* fix(interceptors.go): remove unused AuthUnaryInterceptor function * fix(interceptors.go): remove unused AuthStreamInterceptor default case * fix(interceptors.go): change auth role in AuthStreamInterceptor to auth.ConsumerRole * fix(interceptors.go): change auth role in AuthStreamInterceptor to auth.ConsumerRole * fix(interceptors_test.go): remove unused TestAuthUnaryInterceptor function * fix(interceptors_test.go): remove unused TestAuthUnaryInterceptor test case * fix(interceptors_test.go): remove unused TestAuthStreamInterceptor test case * fix(interceptors_test.go): add test case for authorized result method in TestAuthStreamInterceptor * fix(interceptors_test.go): add test case for unauthorized result method in TestAuthStreamInterceptor * fix(grpc.go): remove unused unary interceptor in grpcServerOptions * fix(grpc.go): change stream interceptor in grpcServerOptions to use NewAuthInterceptor Signed-off-by: SammyOina <[email protected]>
|
I would like that we block this PR until we decide if we would like to mandate Docker as an algorithm execution isolate. If we mandate Docker, that we do not need to pollute Computation and Manifest with Requirements. |
I had reported some of my findings on docker on this issue #134 |
|
Closing in favor of #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes